Appropriately wait for worker child process when shutting down via SIGTERM #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayonj
changed the title
shayonj
force-pushed
the
s/exit-waitpid
branch
3 times, most recently
from
5108f53
to
c62ccf5
Compare
…GTERM This way when a SIGTERM is issued to a puma cluster (master process) the shutting down of workers/child processes successfully completes. Before this, it meant the master process will wait for every child process, not just puma specific child process. Which meant even though the workers were to successfully terminate, the server never exits as intended.
shayonj
force-pushed
the
s/exit-waitpid
branch
from
c62ccf5
to
b9500f3
Compare
MSP-Greg
added a commit
to MSP-Greg/puma
that referenced
this pull request
Nov 19, 2017
nateberkopec
pushed a commit
that referenced
this pull request
Nov 20, 2017
|
@nateberkopec @MSP-Greg is this good to close (and so the mentioned issue)? Looks the changes were rolled into a single PR. :) |
|
Please accept my apology, as I should have mentioned you in the PR. It was kind of a 'if all three are rolled into one, this should work' thing... |
|
Yes - thanks you for opening, @shayonj. |
|
not at all @MSP-Greg. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way when a SIGTERM is issued to a puma cluster (master process)
the shutting down of workers/child processes successfully completes.
Before this, it meant the master process will wait for every child process, not just
puma specific child process. Which meant even though the workers were to
successfully terminate, the server never exits as intended.
Issue: #1386